Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resources added for Helsinki #327

Merged
merged 14 commits into from
Jul 9, 2024
Merged

fix: resources added for Helsinki #327

merged 14 commits into from
Jul 9, 2024

Conversation

TenzDelek
Copy link
Contributor

Description
resources added for Helsinki
image

Related issue(s)
Fixes #325

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit f188743
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/668bfe617bad1500081b1b26
😎 Deploy Preview https://deploy-preview-327--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thulieblack
Copy link
Member

@TenzDelek, why not replicate what we did last year and something similar to this

image

https://conference.2023.asyncapi.com/

@TenzDelek
Copy link
Contributor Author

@TenzDelek, why not replicate what we did last year and something similar to this

image

https://conference.2023.asyncapi.com/

@thulieblack sure, will implement that

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

➕1 on the suggestion Thulie made about the resources.

@TenzDelek
Copy link
Contributor Author

  • 1 on the suggestion Thulie made about the resources.

Have made the changes as per @thulieblack said 😀

@ashmit-coder
Copy link
Collaborator

ashmit-coder commented Jun 8, 2024

Hey @TenzDelek can you make it centered does not look good when there is just one element in the drop down.
Screenshot from 2024-06-08 10-22-51

@TenzDelek
Copy link
Contributor Author

Hey @TenzDelek can you make it centered does not look good when there is just one element in the drop down.

Screenshot from 2024-06-08 10-22-51

Sure, have my nimcet exam today, will start the changes from tomorrow 👍

@TenzDelek
Copy link
Contributor Author

Hey @TenzDelek can you make it centered does not look good when there is just one element in the drop down. Screenshot from 2024-06-08 10-22-51

@ashmit-coder have done the centering :)

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@thulieblack thulieblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thulieblack
Copy link
Member

/ptal

@asyncapi-bot
Copy link
Contributor

@AceTheCreator Please take a look at this PR. Thanks! 👋

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TenzDelek i think you should take a look at the alignment on the venue menu, you've probably messed with he alignment.

@TenzDelek
Copy link
Contributor Author

@TenzDelek i think you should take a look at the alignment on the venue menu, you've probably messed with he alignment.

hmm.. interesting, the plan was to move the items to the center as it doesn't look great when there is only one item as suggested by @ashmit-coder . should i write a logic for it or make it back to default layout??
cc @AceTheCreator

@AceTheCreator
Copy link
Member

@TenzDelek i think you should take a look at the alignment on the venue menu, you've probably messed with he alignment.

hmm.. interesting, the plan was to move the items to the center as it doesn't look great when there is only one item as suggested by @ashmit-coder . should i write a logic for it or make it back to default layout?? cc @AceTheCreator

Yes, please

@TenzDelek
Copy link
Contributor Author

@TenzDelek i think you should take a look at the alignment on the venue menu, you've probably messed with he alignment.

hmm.. interesting, the plan was to move the items to the center as it doesn't look great when there is only one item as suggested by @ashmit-coder . should i write a logic for it or make it back to default layout?? cc @AceTheCreator

Yes, please

yes for implementing a further function or making it back to default? :), from my perspective, i think reverting it back to the default sounds better as there will be further resources added in the near future.

@thulieblack
Copy link
Member

@TenzDelek whats the status here?

@TenzDelek
Copy link
Contributor Author

@TenzDelek whats the status here?

@thulieblack done :)

@thulieblack
Copy link
Member

you have some conflicts you need to resolve first

@thulieblack
Copy link
Member

@AceTheCreator check the changes

@AceTheCreator
Copy link
Member

@TenzDelek, i noticed a bug. when I hover on the resources tab, the venue dropdown gets activated. Can you look into that?

@TenzDelek
Copy link
Contributor Author

@AceTheCreator this should fix it :)

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TenzDelek the dropdown options have became unclickable, due to changes.

It has affected the venues section as well, ptal.

@ashmit-coder
Copy link
Collaborator

@AceTheCreator
Copy link
Member

@TenzDelek can you look into rectifying the issue with your PR?

@TenzDelek
Copy link
Contributor Author

@ashmit-coder @AceTheCreator Done with the Change :)

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@AceTheCreator AceTheCreator merged commit 6c6ab90 into asyncapi:master Jul 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Helsinki Slides Link Resources
6 participants